Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLOCKBACK-166] GPOS - dividend distribution for UIAs #200

Merged
merged 1 commit into from
Oct 26, 2019
Merged

[BLOCKBACK-166] GPOS - dividend distribution for UIAs #200

merged 1 commit into from
Oct 26, 2019

Conversation

srpatel19590
Copy link

Fixed small bug and added test case

oxarbitrage
oxarbitrage approved these changes Oct 25, 2019
View reviewed changes
Copy link

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An great job in the test case. We can consider to add some of the new created functions into the gpos_fixture at the top if we need any of them in another test case.

@oxarbitrage oxarbitrage merged commit aef57f1 into qa_gpos_18.04 Oct 26, 2019
@srpatel19590
Copy link
Author

@oxarbitrage Sure. I will do that. Thank you!

@bobinson bobinson added this to the v0.2 milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@pbattu123 pbattu123 Awaiting requested review from pbattu123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@srpatel19590 @oxarbitrage @bobinson